[Local Catalog] Add POS catalog request & download endpoints for full sync #16298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaclync
changed the title
Collaborator
|
|
1 task
joshheald
approved these changes
Oct 31, 2025
| /// - Returns: List of products and variations in the POS catalog. | ||
| // periphery:ignore - TODO - remove this periphery ignore comment when this endpoint is integrated with catalog sync | ||
| public func downloadCatalog(for siteID: Int64, downloadURL: String) async throws -> POSCatalogResponse { | ||
| // TODO: WOOMOB-1173 - move download task to the background using `URLSessionConfiguration.background` |
Contributor
There was a problem hiding this comment.
👍 Just what I was going to say 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-1609
Just one review is required.
Description
This PR adds new catalog API endpoints to
POSCatalogSyncRemotethat enable POS catalog generation and download functionality.This is an updated version of the previous implementation from #16041 and #16042, adapted to work with the latest catalog API design pcShBQ-3wD-p2#comment-5426 with one endpoint to request catalog generation.
The changes introduce two new methods to the networking layer:
requestCatalogGeneration(for:forceGeneration:)- Initiates catalog generation and returns the status with optional download URLdownloadCatalog(for:downloadURL:)- Downloads and parses the generated catalog file into products and variationsAdditionally, this PR removes unused mock response files for the catalog status endpoint that is no longer needed.
Test Steps
Just CI for now, as the endpoints aren't used in the app in this PR. I tested the endpoints in a separate branch with supported stores.
RELEASE-NOTES.txtif necessary.